From 9fc61803f1337ef7744645f3196b45ab52884916 Mon Sep 17 00:00:00 2001 From: xiaojiazhu <258828110.@qq.com> Date: Sat, 9 Sep 2023 06:44:41 -0700 Subject: [PATCH] Status code module add clang-tidy check. --- utils/Log/CMakeLists.txt | 1 - utils/StatusCode/CMakeLists.txt | 20 ++++++++++++++++++++ utils/StatusCode/src/StatusCode.c | 7 ++----- 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/utils/Log/CMakeLists.txt b/utils/Log/CMakeLists.txt index 002e3f5..cd4d80e 100644 --- a/utils/Log/CMakeLists.txt +++ b/utils/Log/CMakeLists.txt @@ -28,7 +28,6 @@ add_library(${ABSTRACT_TARGET} STATIC ${ABSTRACT_SRC_FILES}) add_library(${IMPL_TARGET} STATIC ${IMPL_SRC_FILES} ${EASYLOGGING_SRC_FILES}) target_link_libraries(${IMPL_TARGET} ${ABSTRACT_TARGET}) - if ("${CLANG_TIDY_SUPPORT}" MATCHES "true") add_custom_target( Log_code_check diff --git a/utils/StatusCode/CMakeLists.txt b/utils/StatusCode/CMakeLists.txt index 95ab6c9..c1f24aa 100644 --- a/utils/StatusCode/CMakeLists.txt +++ b/utils/StatusCode/CMakeLists.txt @@ -22,3 +22,23 @@ set(TARGET_NAME StatusCode) add_library(${TARGET_NAME} STATIC ${SRC_FILES}) target_link_libraries(${TARGET_NAME} Log) +if ("${CLANG_TIDY_SUPPORT}" MATCHES "true") +add_custom_target( + StatusCode_code_check + COMMAND ${CLANG_TIDY_EXE} + -checks='${CLANG_TIDY_CHECKS}' + --header-filter=.* + --system-headers=false + ${SRC_FILES} + ${CLANG_TIDY_CONFIG} + -p ${CMAKE_SOURCE_DIR_IPCSDK}/cmake-shell-linux + WORKING_DIRECTORY ${UTILS_SOURCE_PATH}/StatusCode +) +add_custom_command( + TARGET ${TARGET_NAME} + # TARGET ${ABSTRACT_TARGET} + PRE_BUILD + COMMAND make StatusCode_code_check + WORKING_DIRECTORY ${PROJECT_ROOT_PATH}/cmake-shell-linux/ +) +endif() \ No newline at end of file diff --git a/utils/StatusCode/src/StatusCode.c b/utils/StatusCode/src/StatusCode.c index 60ac928..2d81be9 100644 --- a/utils/StatusCode/src/StatusCode.c +++ b/utils/StatusCode/src/StatusCode.c @@ -39,9 +39,6 @@ const StatusCode CreateStatusCode(const long int code) { return NewStatusCode(code); } - else - { - LogError("undefined code.\n"); - return NewStatusCode(STATUS_CODE_END); - } + LogError("undefined code.\n"); + return NewStatusCode(STATUS_CODE_END); }